[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

Fri Jan 7 01:44:51 PST 2022

salman-javed-nz added a comment.

In D116378#3226780 <https://reviews.llvm.org/D116378#3226780>, @carlosgalvezp wrote:

> By the way, the similar problem exists in Clang compiler. I have written in cfe-dev <https://lists.llvm.org/pipermail/cfe-dev/2021-December/069648.html>, Discourse <https://llvm.discourse.group/t/compiler-warnings-in-macros-coming-from-system-headers/5107> and submitted an issue <https://github.com/llvm/llvm-project/issues/52944> without any feedback so far (I understand it's been vacation). Do you think it would be beneficial to implement a similar fix there? I don't know if the fix is as straightforward as in clang-tidy or if it will have to be done on a per-check basis.

Speaking as just a user of the compiler and not a contributor (I tend to stick in Clang-Tidy land), yes, a fix would be great. Especially if you're getting unactionable warnings coming from STM32 libraries - it's a platform I have to develop for too. Not sure where in Clang you would make the change. At a cursory glance, the commits in `Clang/` I saw to do with stopping system header warnings from bubbling up were done in the individual warnings, not in common code. Best to check with someone who works in that area.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116378/new/

https://reviews.llvm.org/D116378