[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

Thu Jan 6 23:36:35 PST 2022

carlosgalvezp added a comment.

In D116378#3226242 <https://reviews.llvm.org/D116378#3226242>, @salman-javed-nz wrote:

> This resolves the long-standing gripe I have with clang-tidy raising warnings about GoogleTest macros expanded in my code. Good work.
> Do you think we can close issues #44873 <https://github.com/llvm/llvm-project/issues/44873>, #43325 <https://github.com/llvm/llvm-project/issues/43325>, and #31587 <https://github.com/llvm/llvm-project/issues/31587> now that we have this fix?

Thanks! It has been bugging me for long time as well :)

It seems to me those issues could be closed, yes.

By the way, the similar problem exists in Clang compiler. I have written in cfe-dev <https://lists.llvm.org/pipermail/cfe-dev/2021-December/069648.html>, Discourse <https://llvm.discourse.group/t/compiler-warnings-in-macros-coming-from-system-headers/5107> and submitted an issue <https://github.com/llvm/llvm-project/issues/52944> without any feedback so far (I understand it's been vacation). Do you think it would be beneficial to implement a similar fix there? I don't know if the fix is as straightforward as in clang-tidy or if it will have to be done on a per-check basis.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116378/new/

https://reviews.llvm.org/D116378