[clang] b8e03be - [PS4][DWARF] Explicitly set default DWARF version to 4

[via cfe-commits]

Follow-up to test this explicitly (I thought it was already!) in
https://github.com/llvm/llvm-project/commit/fa17c0e27ac5e874e0d0ce3be9146ee3f5a99016

Thanks for catching this!
--paulr

From: David Blaikie <dblaikie at gmail.com>
Sent: Monday, December 6, 2021 10:44 PM
To: Robinson, Paul <paul.robinson at sony.com>; Paul Robinson <llvmlistbot at llvm.org>
Cc: cfe-commits <cfe-commits at lists.llvm.org>
Subject: Re: [clang] b8e03be - [PS4][DWARF] Explicitly set default DWARF version to 4

Guess this is untestable right now, since it's overriding with the same value? Maybe worth adding an explicit test for the PS4 default - so that the test would fail /if/ the generic (non-PS4) default was changed (which we'll hopefully change in the near future)?

On Tue, Nov 30, 2021 at 8:59 AM Paul Robinson via cfe-commits <cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>> wrote:

Author: Paul Robinson
Date: 2021-11-30T08:58:40-08:00
New Revision: b8e03be88dc87303f7401ea7b9906947ac67a6db

URL: https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db<https://urldefense.com/v3/__https:/github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db__;!!JmoZiZGBv3RvKRSx!sxfCcNOMAtJsbc-aOyBzF6vXNXya8ARhlBndaieQNWxs8xQJv55Wovs6ftwnmfoIQA$>
DIFF: https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db.diff<https://urldefense.com/v3/__https:/github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db.diff__;!!JmoZiZGBv3RvKRSx!sxfCcNOMAtJsbc-aOyBzF6vXNXya8ARhlBndaieQNWxs8xQJv55Wovs6ftwhpeYwuA$>

LOG: [PS4][DWARF] Explicitly set default DWARF version to 4

Added:


Modified:
    clang/lib/Driver/ToolChains/PS4CPU.h

Removed:



################################################################################
diff  --git a/clang/lib/Driver/ToolChains/PS4CPU.h b/clang/lib/Driver/ToolChains/PS4CPU.h
index 82f9523f84fb8..4bedabaf267c0 100644
--- a/clang/lib/Driver/ToolChains/PS4CPU.h
+++ b/clang/lib/Driver/ToolChains/PS4CPU.h
@@ -80,6 +80,7 @@ class LLVM_LIBRARY_VISIBILITY PS4CPU : public Generic_ELF {
     return LangOptions::SSPStrong;
   }

+  unsigned GetDefaultDwarfVersion() const override { return 4; }
   llvm::DebuggerKind getDefaultDebuggerTuning() const override {
     return llvm::DebuggerKind::SCE;
   }



_______________________________________________
cfe-commits mailing list
cfe-commits at lists.llvm.org<mailto:cfe-commits at lists.llvm.org>
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits<https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits__;!!JmoZiZGBv3RvKRSx!sxfCcNOMAtJsbc-aOyBzF6vXNXya8ARhlBndaieQNWxs8xQJv55Wovs6ftwuovcsJQ$>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220104/97e222ea/attachment.html>