<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple" style="word-wrap:break-word">
<div class="WordSection1">
<p class="MsoNormal">Follow-up to test this explicitly (I thought it was already!) in<o:p></o:p></p>
<p class="MsoNormal"><a href="https://github.com/llvm/llvm-project/commit/fa17c0e27ac5e874e0d0ce3be9146ee3f5a99016">https://github.com/llvm/llvm-project/commit/fa17c0e27ac5e874e0d0ce3be9146ee3f5a99016</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks for catching this!<o:p></o:p></p>
<p class="MsoNormal">--paulr<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #E1E1E1 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b>From:</b> David Blaikie <dblaikie@gmail.com> <br>
<b>Sent:</b> Monday, December 6, 2021 10:44 PM<br>
<b>To:</b> Robinson, Paul <paul.robinson@sony.com>; Paul Robinson <llvmlistbot@llvm.org><br>
<b>Cc:</b> cfe-commits <cfe-commits@lists.llvm.org><br>
<b>Subject:</b> Re: [clang] b8e03be - [PS4][DWARF] Explicitly set default DWARF version to 4<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">Guess this is untestable right now, since it's overriding with the same value? Maybe worth adding an explicit test for the PS4 default - so that the test would fail /if/ the generic (non-PS4) default was changed (which we'll hopefully change
in the near future)?<o:p></o:p></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<div>
<p class="MsoNormal">On Tue, Nov 30, 2021 at 8:59 AM Paul Robinson via cfe-commits <<a href="mailto:cfe-commits@lists.llvm.org">cfe-commits@lists.llvm.org</a>> wrote:<o:p></o:p></p>
</div>
<blockquote style="border:none;border-left:solid #CCCCCC 1.0pt;padding:0in 0in 0in 6.0pt;margin-left:4.8pt;margin-right:0in">
<p class="MsoNormal"><br>
Author: Paul Robinson<br>
Date: 2021-11-30T08:58:40-08:00<br>
New Revision: b8e03be88dc87303f7401ea7b9906947ac67a6db<br>
<br>
URL: <a href="https://urldefense.com/v3/__https:/github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db__;!!JmoZiZGBv3RvKRSx!sxfCcNOMAtJsbc-aOyBzF6vXNXya8ARhlBndaieQNWxs8xQJv55Wovs6ftwnmfoIQA$" target="_blank">
https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db</a><br>
DIFF: <a href="https://urldefense.com/v3/__https:/github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db.diff__;!!JmoZiZGBv3RvKRSx!sxfCcNOMAtJsbc-aOyBzF6vXNXya8ARhlBndaieQNWxs8xQJv55Wovs6ftwhpeYwuA$" target="_blank">
https://github.com/llvm/llvm-project/commit/b8e03be88dc87303f7401ea7b9906947ac67a6db.diff</a><br>
<br>
LOG: [PS4][DWARF] Explicitly set default DWARF version to 4<br>
<br>
Added: <br>
<br>
<br>
Modified: <br>
clang/lib/Driver/ToolChains/PS4CPU.h<br>
<br>
Removed: <br>
<br>
<br>
<br>
################################################################################<br>
diff --git a/clang/lib/Driver/ToolChains/PS4CPU.h b/clang/lib/Driver/ToolChains/PS4CPU.h<br>
index 82f9523f84fb8..4bedabaf267c0 100644<br>
--- a/clang/lib/Driver/ToolChains/PS4CPU.h<br>
+++ b/clang/lib/Driver/ToolChains/PS4CPU.h<br>
@@ -80,6 +80,7 @@ class LLVM_LIBRARY_VISIBILITY PS4CPU : public Generic_ELF {<br>
return LangOptions::SSPStrong;<br>
}<br>
<br>
+ unsigned GetDefaultDwarfVersion() const override { return 4; }<br>
llvm::DebuggerKind getDefaultDebuggerTuning() const override {<br>
return llvm::DebuggerKind::SCE;<br>
}<br>
<br>
<br>
<br>
_______________________________________________<br>
cfe-commits mailing list<br>
<a href="mailto:cfe-commits@lists.llvm.org" target="_blank">cfe-commits@lists.llvm.org</a><br>
<a href="https://urldefense.com/v3/__https:/lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits__;!!JmoZiZGBv3RvKRSx!sxfCcNOMAtJsbc-aOyBzF6vXNXya8ARhlBndaieQNWxs8xQJv55Wovs6ftwuovcsJQ$" target="_blank">https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits</a><o:p></o:p></p>
</blockquote>
</div>
</div>
</div>
</body>
</html>