[PATCH] D116159: [ARM][AArch64] clang support for Armv9.3-A

[Tomas Matheson via Phabricator via cfe-commits]

tmatheson added inline comments.


================
Comment at: clang/test/Driver/arm-cortex-cpus.c:445
+// RUN: %clang -target armv9.3a -mlittle-endian -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V93A %s
+// RUN: %clang -target arm -march=armv9.3a -mlittle-endian -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V93A %s
+// RUN: %clang -target arm -mlittle-endian -march=armv9.3-a -mlittle-endian -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V93A %s
----------------
nickdesaulniers wrote:
> Is this `RUN` line a duplicate of L443? Maybe you meant to test a hyphen in the `march`?
Good catch, I've removed it. The same redundancy has been copy-pasted a few times by the look of it. Looks like the origins are in testing that armv8 and armv8a are synonymous, which doesn't seem to be the case for later versions.

I have created D116415 for the occurrences.


================
Comment at: clang/test/Driver/arm-cortex-cpus.c:446
+// RUN: %clang -target arm -march=armv9.3a -mlittle-endian -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V93A %s
+// RUN: %clang -target arm -mlittle-endian -march=armv9.3-a -mlittle-endian -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V93A %s
+// CHECK-V93A: "-cc1"{{.*}} "-triple" "armv9.3{{.*}}" "-target-cpu" "generic"
----------------
nickdesaulniers wrote:
> nickdesaulniers wrote:
> > how about thumb targets? I recognize this test doesn't already do so for older extensions.
> This test sets `-mlittle-endian` twice. Is that intentional? Should the aarch64 test above `clang/test/Driver/aarch64-cpus.c` also have such a test, or should this `RUN` line be removed? Or was something else meant to be tested?
Also copy-pasted from above; I don't see any point to it, so removed. See also D116415.


================
Comment at: clang/test/Driver/arm-cortex-cpus.c:446
+// RUN: %clang -target arm -march=armv9.3a -mlittle-endian -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V93A %s
+// RUN: %clang -target arm -mlittle-endian -march=armv9.3-a -mlittle-endian -### -c %s 2>&1 | FileCheck -check-prefix=CHECK-V93A %s
+// CHECK-V93A: "-cc1"{{.*}} "-triple" "armv9.3{{.*}}" "-target-cpu" "generic"
----------------
tmatheson wrote:
> nickdesaulniers wrote:
> > nickdesaulniers wrote:
> > > how about thumb targets? I recognize this test doesn't already do so for older extensions.
> > This test sets `-mlittle-endian` twice. Is that intentional? Should the aarch64 test above `clang/test/Driver/aarch64-cpus.c` also have such a test, or should this `RUN` line be removed? Or was something else meant to be tested?
> Also copy-pasted from above; I don't see any point to it, so removed. See also D116415.
The above tests seem so be considered sufficient since 8.2, nothing much has changed afaik so I don't see any need to add them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116159/new/

https://reviews.llvm.org/D116159