[PATCH] D116314: [clang-format] Add style to separate definition blocks

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Dec 28 11:50:01 PST 2021


HazardyKnusperkeks added inline comments.


================
Comment at: clang/lib/Format/Format.cpp:2027
+// namespaces by inserting a line break between them.
+class DefinitionBlockSeparator : public TokenAnalyzer {
+public:
----------------
curdeius wrote:
> Please consider moving it to a different file.
Yes please.


================
Comment at: clang/lib/Format/Format.cpp:2114
+      if (Result.add(R))
+        return;
+  }
----------------
Why only add the first replacement?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116314/new/

https://reviews.llvm.org/D116314



More information about the cfe-commits mailing list