[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

[Salman Javed via Phabricator via cfe-commits]

salman-javed-nz added a comment.

In D108560#3192081 <https://reviews.llvm.org/D108560#3192081>, @kadircet wrote:

> Hi @salman-javed-nz !
> Also I am not sure what kind of timelines you have in mind for the performance improvements, but I think it would be great to have them before LLVM-14 release, as otherwise we might have some (extra) discrepancies between clang-tidy CLI vs clangd integration, which would be unfortunate.

Hi @kadircet. Today I fixed the last of the bugs in my caching implementation. I still need to run some tests to quantify what the performance improvement is before submitting the code for a review.

> Also I am not sure what kind of timelines you have in mind for the performance improvements, but I think it would be great to have them before LLVM-14 release, as otherwise we might have some (extra) discrepancies between clang-tidy CLI vs clangd integration, which would be unfortunate.

Definitely before Clang 14. The patch is a few days away, not weeks or months away.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108560/new/

https://reviews.llvm.org/D108560