[PATCH] D108560: [clang-tidy] Add support for `NOLINTBEGIN` ... `NOLINTEND` comments

Tue Dec 14 06:04:52 PST 2021

kadircet added a comment.

Hi @salman-javed-nz !

Thanks for the great work and working on the performance improvements. Just FYI, we are also disabling this in clangd's clang-tidy integration as it is increasing the latency of diagnostic generation.
It would be great if you also provided some updates to the call-sites once your performance fix lands. See https://reviews.llvm.org/D115650 for an example.

Also I am not sure what kind of timelines you have in mind for the performance improvements, but I think it would be great to have them before LLVM-14 release, as otherwise we might have some (extra) discrepancies between clang-tidy CLI vs clangd integration, which would be unfortunate.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108560/new/

https://reviews.llvm.org/D108560