[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

[Alok Kumar Sharma via Phabricator via cfe-commits]

alok added inline comments.


================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:4513
         Scope.addPrivate(Pair.first, [Replacement]() { return Replacement; });
+        if (auto *DI = CGF.getDebugInfo()) {
+          DI->EmitDeclareOfAutoVariable(Pair.first, Pair.second.getPointer(),
----------------
djtodoro wrote:
> I think we can get rid of curly brackets.
Sure, I am doing it.


================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:4515
+          DI->EmitDeclareOfAutoVariable(Pair.first, Pair.second.getPointer(),
+                                        CGF.Builder, true);
+        }
----------------
djtodoro wrote:
> 
Thanks. I am updating it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114504/new/

https://reviews.llvm.org/D114504