[PATCH] D114504: [clang][DebugInfo] Debug support for private variables inside an OpenMP task construct

[Djordje Todorovic via Phabricator via cfe-commits]

djtodoro added a comment.

This looks reasonable to me (some nits included).



================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:4513
         Scope.addPrivate(Pair.first, [Replacement]() { return Replacement; });
+        if (auto *DI = CGF.getDebugInfo()) {
+          DI->EmitDeclareOfAutoVariable(Pair.first, Pair.second.getPointer(),
----------------
I think we can get rid of curly brackets.


================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:4515
+          DI->EmitDeclareOfAutoVariable(Pair.first, Pair.second.getPointer(),
+                                        CGF.Builder, true);
+        }
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114504/new/

https://reviews.llvm.org/D114504