[PATCH] D113899: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks!



================
Comment at: clang-tools-extra/clangd/Selection.cpp:504
   bool TraverseDecl(Decl *X) {
-    if (X && isa<TranslationUnitDecl>(X))
+    if (isa_and_nonnull<TranslationUnitDecl>(X))
       return Base::TraverseDecl(X); // Already pushed by constructor.
----------------
kuhnel wrote:
> kadircet wrote:
> > while here `llvm::isa_and_nonnull` we try to qualify symbols from llvm namespace.
> Sorry, I'm not getting what you wanted to say. 
> 
> You want me to add a `llvm::`?
> Or is it about a `operator bool()`(however I didn't find one for `Decl` )?
> You want me to add a llvm::?

right, I was asking for qualifying the symbol with `llvm::` namespace specifier.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113899/new/

https://reviews.llvm.org/D113899