[PATCH] D113899: [NFC][clangd] fix clang-tidy finding on isa_and_nonnull
Christian Kühnel via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Nov 17 05:58:07 PST 2021
kuhnel added inline comments.
================
Comment at: clang-tools-extra/clangd/Selection.cpp:504
bool TraverseDecl(Decl *X) {
- if (X && isa<TranslationUnitDecl>(X))
+ if (isa_and_nonnull<TranslationUnitDecl>(X))
return Base::TraverseDecl(X); // Already pushed by constructor.
----------------
kadircet wrote:
> while here `llvm::isa_and_nonnull` we try to qualify symbols from llvm namespace.
Sorry, I'm not getting what you wanted to say.
You want me to add a `llvm::`?
Or is it about a `operator bool()`(however I didn't find one for `Decl` )?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D113899/new/
https://reviews.llvm.org/D113899
More information about the cfe-commits
mailing list