[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

Carlos Galvez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Nov 15 05:51:59 PST 2021


carlosgalvezp added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/GlobList.h:50-52
+/// A \p GlobList that caches search results, so that search is performed only
+/// once for the same query.
+class CachedGlobList {
----------------
whisperity wrote:
> If `CachedGlobList` //is-a// `GlobList`, wouldn't it be better to express the inheritance relationship?
Yes, that makes total sense to me. I wasn't sure if it was OK to do the move + change the code itself in the same patch. Will fix!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113422/new/

https://reviews.llvm.org/D113422



More information about the cfe-commits mailing list