[PATCH] D113422: [clang-tidy][NFC] Move CachedGlobList to GlobList.h

[Whisperity via Phabricator via cfe-commits]

whisperity added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/GlobList.h:50-52
+/// A \p GlobList that caches search results, so that search is performed only
+/// once for the same query.
+class CachedGlobList {
----------------
If `CachedGlobList` //is-a// `GlobList`, wouldn't it be better to express the inheritance relationship?


================
Comment at: clang-tools-extra/clang-tidy/GlobList.h:61
+private:
+  GlobList Globs;
+  enum Tristate { None, Yes, No };
----------------
(considering the logically first data member is the conceptual base class)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113422/new/

https://reviews.llvm.org/D113422