[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

Alex Bradbury via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 28 05:57:53 PDT 2021


asb added a comment.
Herald added a reviewer: luke957.

This doesn't apply cleanly to current HEAD, could you please rebase?

I think the second part of this that you list, where the ISA extension version becomes optional is undesirable. We made the explicit choice of requiring the version string to be specified for experimental extensions in order to make it even clearer up-front that these are subject to change (and to allow people to catch easily when the supported ISA version has changed in a compiler update).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112359/new/

https://reviews.llvm.org/D112359



More information about the cfe-commits mailing list