[PATCH] D112359: [RISCV] Unify depedency check and extension implication parsing logics

Yueh-Ting Chen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 26 03:34:23 PDT 2021


eopXD added a comment.

The test cases are modified because unifying the logic here shows the place where clang / llvm deal with target feature inconsistently.
I think it would be beneficial if we have them consistent.

- Test cases with `clang -cc1` originally don't do dependency check to target feature specified
  - This patch add target feature so that dependency checks can pass

- Originally clang driver's `-march` enforces version to be specified, while llvm allows `.attribute arch` to not specify version (and picks the default one)
  - This patch lets clang search for default version if no version is specified (so delete `NOVERS` test case in `clang/test/Driver/riscv-arch.c`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112359/new/

https://reviews.llvm.org/D112359



More information about the cfe-commits mailing list