[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 18 03:49:35 PDT 2021


ChuanqiXu added a comment.

In D108696#3069723 <https://reviews.llvm.org/D108696#3069723>, @avogelsgesang wrote:

> Hi @ChuanqiXu
>
> sorry for what might be naive questions, but just to make sure I understand the context of this patch correctly:

Hi, you are welcome : )

> This patch fixes the look up of the `coroutine_traits`, so that clang now search both the `std` and the `std::experimental` namespace. As such, it must land before D109433 <https://reviews.llvm.org/D109433> since otherwise the new `std::coroutine_traits` wouldn't be found by the compiler, correct?

Yes, correct.

> Also, does this patch enable me to use `clang-cl` to build programs which use the coroutine header from Microsoft's STL <https://github.com/microsoft/STL/blob/main/stl/inc/coroutine>? Or are there still other incompatibilities between clang and the Microsoft STL with regards to coroutines?

After this patch, it should be able to compile <coroutine> MS STL. Otherwise, there must be a bug in either the clang part or in the MS STL part.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108696/new/

https://reviews.llvm.org/D108696



More information about the cfe-commits mailing list