[PATCH] D108696: [Coroutines] [Frontend] Lookup in std namespace first

Adrian Vogelsgesang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 18 03:39:57 PDT 2021


avogelsgesang added a comment.

Hi @ChuanqiXu

sorry for what might be naive questions, but just to make sure I understand the context of this patch correctly:

This patch fixes the look up of the `coroutine_traits`, so that clang now search both the `std` and the `std::experimental` namespace. As such, it must land before D109433 <https://reviews.llvm.org/D109433> since otherwise the new `std::coroutine_traits` wouldn't be found by the compiler, correct?

Also, does this patch enable me to use `clang-cl` to build programs which use the coroutine header from Microsoft's STL <https://github.com/microsoft/STL/blob/main/stl/inc/coroutine>? Or are there still other incompatibilities between clang and the Microsoft STL with regards to coroutines?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108696/new/

https://reviews.llvm.org/D108696



More information about the cfe-commits mailing list