[PATCH] D111229: [PowerPC][Builtin] Allowing __rlwnm to accept a variable as a shift parameter

Victor Huang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Oct 12 13:11:58 PDT 2021


NeHuang accepted this revision as: NeHuang.
NeHuang added a comment.
This revision is now accepted and ready to land.

Thanks. LGTM. One minor can be addressed when commit it.



================
Comment at: clang/test/CodeGen/builtins-ppc-xlcompat-rotate.c:71
+
+  /*shift = 31, mask = 0x1FF = 511*/
+  unsigned int res = __builtin_ppc_rlwnm(ui, shift, 0x1FF);
----------------
please remove `shift = 31,` in the comment 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111229/new/

https://reviews.llvm.org/D111229



More information about the cfe-commits mailing list