[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

[Samuel Marks via Phabricator via cfe-commits]

SamuelMarks updated this revision to Diff 378467.
SamuelMarks added a comment.

push/popd for build dirs


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111490/new/

https://reviews.llvm.org/D111490

Files:
  clang/docs/HowToSetupToolingForLLVM.rst
  clang/docs/LibASTMatchersTutorial.rst
  libcxx/appveyor-reqs-install.cmd


Index: libcxx/appveyor-reqs-install.cmd
===================================================================
--- libcxx/appveyor-reqs-install.cmd
+++ libcxx/appveyor-reqs-install.cmd
@@ -38,7 +38,7 @@
 :: Install Ninja
 ::###########################################################################
 if NOT EXIST ninja (
-  appveyor DownloadFile https://github.com/ninja-build/ninja/releases/download/v1.6.0/ninja-win.zip -FileName ninja.zip
+  appveyor DownloadFile https://github.com/ninja-build/ninja/releases/download/v1.10.2/ninja-win.zip -FileName ninja.zip
   7z x ninja.zip -oC:\projects\deps\ninja > nul
   rm ninja.zip
 )
Index: clang/docs/LibASTMatchersTutorial.rst
===================================================================
--- clang/docs/LibASTMatchersTutorial.rst
+++ clang/docs/LibASTMatchersTutorial.rst
@@ -30,29 +30,31 @@
 .. code-block:: console
 
       cd ~/clang-llvm
-      git clone git://github.com/ninja-build/ninja.git
+      git clone https://github.com/ninja-build/ninja
+      pushd ninja
       ./configure.py --bootstrap
       sudo cp ninja /usr/local/bin/
+      popd
 
-      cd ~/clang-llvm
       git clone git://cmake.org/stage/cmake.git
       cd cmake
       git checkout next
       ./bootstrap
       make
       sudo make install
+      popd
 
 Okay. Now we'll build Clang!
 
 .. code-block:: console
 
-      cd ~/clang-llvm
-      mkdir build && cd build
+      mkdir build && pushd build
       cmake -G Ninja ../llvm -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra" -DLLVM_BUILD_TESTS=ON  # Enable tests; default is off.
       ninja
       ninja check       # Test LLVM only.
       ninja clang-test  # Test Clang only.
       ninja install
+      popd
 
 And we're live.
 
Index: clang/docs/HowToSetupToolingForLLVM.rst
===================================================================
--- clang/docs/HowToSetupToolingForLLVM.rst
+++ clang/docs/HowToSetupToolingForLLVM.rst
@@ -154,7 +154,7 @@
 
 .. code-block:: console
 
-  $ git clone git://github.com/ninja-build/ninja.git
+  $ git clone https://github.com/ninja-build/ninja
   $ cd ninja/
   $ ./configure.py --bootstrap
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111490.378467.patch
Type: text/x-patch
Size: 2136 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211009/f65d76fe/attachment.bin>