[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)
Samuel Marks via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Oct 9 11:58:58 PDT 2021
SamuelMarks added inline comments.
================
Comment at: clang/docs/LibASTMatchersTutorial.rst:34
- git clone https://github.com/martine/ninja.git
- cd ninja
- git checkout release
----------------
xgupta wrote:
> SamuelMarks wrote:
> > xgupta wrote:
> > > why removed `cd ninja` & `git checkout release`?
> > @xgupta To match how ninja is installed everywhere else in LLVM guides. Also ninja's release branch is almost a year old, whereas its master is 5 days old.
> fine, but we need to cd into ninja directory to run configure step, right?
Good point, I'll fix all of them with pushd and popd
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111490/new/
https://reviews.llvm.org/D111490
More information about the cfe-commits
mailing list