[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

Shivam Gupta via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 9 07:19:27 PDT 2021


xgupta added inline comments.


================
Comment at: clang/docs/HowToSetupToolingForLLVM.rst:157
 
-  $ git clone git://github.com/martine/ninja.git
+  $ git clone git://github.com/ninja-build/ninja.git
   $ cd ninja/
----------------
git -> https


================
Comment at: clang/docs/LibASTMatchersTutorial.rst:33
       cd ~/clang-llvm
-      git clone https://github.com/martine/ninja.git
-      cd ninja
-      git checkout release
-      ./bootstrap.py
-      sudo cp ninja /usr/bin/
+      git clone git://github.com/ninja-build/ninja.git
+      ./configure.py --bootstrap
----------------
https would be the right protocol as per the consistency with other places of docs.


================
Comment at: clang/docs/LibASTMatchersTutorial.rst:34
-      git clone https://github.com/martine/ninja.git
-      cd ninja
-      git checkout release
----------------
why removed `cd ninja` & `git checkout release`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111490/new/

https://reviews.llvm.org/D111490



More information about the cfe-commits mailing list