[PATCH] D111490: [DOCS] Update ninja build doc (new: github link, build command, and chmod requirements)

Samuel Marks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Oct 9 06:59:19 PDT 2021


SamuelMarks created this revision.
SamuelMarks added a project: LLVM.
SamuelMarks requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D111490

Files:
  clang/docs/HowToSetupToolingForLLVM.rst
  clang/docs/LibASTMatchersTutorial.rst


Index: clang/docs/LibASTMatchersTutorial.rst
===================================================================
--- clang/docs/LibASTMatchersTutorial.rst
+++ clang/docs/LibASTMatchersTutorial.rst
@@ -30,11 +30,9 @@
 .. code-block:: console
 
       cd ~/clang-llvm
-      git clone https://github.com/martine/ninja.git
-      cd ninja
-      git checkout release
-      ./bootstrap.py
-      sudo cp ninja /usr/bin/
+      git clone git://github.com/ninja-build/ninja.git
+      ./configure.py --bootstrap
+      sudo cp ninja /usr/local/bin/
 
       cd ~/clang-llvm
       git clone git://cmake.org/stage/cmake.git
Index: clang/docs/HowToSetupToolingForLLVM.rst
===================================================================
--- clang/docs/HowToSetupToolingForLLVM.rst
+++ clang/docs/HowToSetupToolingForLLVM.rst
@@ -143,7 +143,7 @@
 Using Ninja Build System
 =======================================
 
-Optionally you can use the `Ninja <https://github.com/martine/ninja>`_
+Optionally you can use the `Ninja <https://github.com/ninja-build/ninja>`_
 build system instead of make. It is aimed at making your builds faster.
 Currently this step will require building Ninja from sources.
 
@@ -154,9 +154,9 @@
 
 .. code-block:: console
 
-  $ git clone git://github.com/martine/ninja.git
+  $ git clone git://github.com/ninja-build/ninja.git
   $ cd ninja/
-  $ ./bootstrap.py
+  $ ./configure.py --bootstrap
 
 This will result in a single binary ``ninja`` in the current directory.
 It doesn't require installation and can just be copied to any location
@@ -165,7 +165,6 @@
 .. code-block:: console
 
   $ sudo cp ninja /usr/local/bin/
-  $ sudo chmod a+rx /usr/local/bin/ninja
 
 After doing all of this, you'll need to generate Ninja build files for
 LLVM with CMake. You need to make a build directory and run CMake from


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D111490.378446.patch
Type: text/x-patch
Size: 1833 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20211009/79117cd7/attachment.bin>


More information about the cfe-commits mailing list