[PATCH] D110891: [inliner] Mandatory inlining decisions produce remarks

Arthur Eubanks via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 1 11:03:51 PDT 2021


aeubanks added inline comments.


================
Comment at: llvm/lib/Analysis/InlineAdvisor.cpp:72-89
+  void recordUnsuccessfulInliningImpl(const InlineResult &Result) override {
+    if (IsInliningRecommended)
+      ORE.emit([&]() {
+        return OptimizationRemarkMissed(DEBUG_TYPE, "NotInlined", DLoc, Block)
+               << "'" << NV("Callee", Callee) << "' is not AlwaysInline into '"
+               << NV("Caller", Caller)
+               << "': " << NV("Reason", Result.getFailureReason());
----------------
can we add a test for these?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110891/new/

https://reviews.llvm.org/D110891



More information about the cfe-commits mailing list