[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries

[Ye Luo via Phabricator via cfe-commits]

ye-luo added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:62
+                         bool postClangLink);
+void AddStaticDeviceLibs(Compilation *C, const Tool *T, const JobAction *JA,
+                         const InputInfoList *Inputs, const Driver &D,
----------------
saiislam wrote:
> ye-luo wrote:
> > ye-luo wrote:
> > > Differentiate the names of all the three AddStaticDeviceLibs functions and add documentation. Be sure to do document every function added in this patch.
> > @saiislam Fix this?
> I have added documentation along with function definition in CommonArgs.cpp. Should I move it here? I thought keep documentation and code at the same place will improve readability.
The docs are good. I was looking for "Differentiate the names of all the three AddStaticDeviceLibs functions"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105191/new/

https://reviews.llvm.org/D105191