[PATCH] D105191: [Clang][OpenMP] Add partial support for Static Device Libraries
Saiyedul Islam via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 29 07:55:11 PDT 2021
saiislam marked an inline comment as done.
saiislam added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.h:62
+ bool postClangLink);
+void AddStaticDeviceLibs(Compilation *C, const Tool *T, const JobAction *JA,
+ const InputInfoList *Inputs, const Driver &D,
----------------
ye-luo wrote:
> ye-luo wrote:
> > Differentiate the names of all the three AddStaticDeviceLibs functions and add documentation. Be sure to do document every function added in this patch.
> @saiislam Fix this?
I have added documentation along with function definition in CommonArgs.cpp. Should I move it here? I thought keep documentation and code at the same place will improve readability.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105191/new/
https://reviews.llvm.org/D105191
More information about the cfe-commits
mailing list