[PATCH] D110458: [clang] Put original flags on 'Driver args:' crash report line

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 27 06:03:03 PDT 2021


thakis marked an inline comment as done.
thakis added a comment.

Thanks!



================
Comment at: clang/test/Driver/crash-report-clang-cl.c:2
+// RUN: rm -rf %t
+// RUN: mkdir %t
+
----------------
hans wrote:
> These always make me thing the test should "requires: shell", but I think for these commands it should work without, right?
Yes, these work without `REQUIRES: shell`. We require a whole bunch of unix utils on Windows, but we don't require a shell for most tests. That's usually required if doing advanced piping maybe? Actually, looking at `REQUIRES: shell` in tests, many put it there needlessly :/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110458/new/

https://reviews.llvm.org/D110458



More information about the cfe-commits mailing list