[PATCH] D110458: [clang] Put original flags on 'Driver args:' crash report line

[Hans Wennborg via Phabricator via cfe-commits]

hans accepted this revision.
hans added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: clang/lib/Driver/Driver.cpp:1220
+  for (const auto *A : Args) {
+    while (A->getAlias())
+      A = A->getAlias();
----------------
Could put a comment here about why it's calling getAlias() (Or maybe it's just me that finds the getAlias() name confusing.)


================
Comment at: clang/test/Driver/crash-report-clang-cl.c:2
+// RUN: rm -rf %t
+// RUN: mkdir %t
+
----------------
These always make me thing the test should "requires: shell", but I think for these commands it should work without, right?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110458/new/

https://reviews.llvm.org/D110458