[PATCH] D110142: [clang][Driver] Correct runtime path for Arm hard float targets
Fangrui Song via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 21 10:51:26 PDT 2021
MaskRay added inline comments.
================
Comment at: clang/test/Driver/arm-float-abi-runtime-path.c:7
+// RUN: -resource-dir=%S/Inputs/arm_float_abi_runtime_path 2>&1 | FileCheck -check-prefix=ARMHF %s
+// RUN: %clang %s -target armv7-unknown-linux-gnueabihf -print-runtime-dir \
+// RUN: -resource-dir=%S/Inputs/arm_float_abi_runtime_path 2>&1 | FileCheck -check-prefix=ARMHF %s
----------------
Having one of armv7/armv8l is sufficient.
We should use the fewest RUN lines to ensure coverage. As is, spawning 8 clang processes is too expensive.
================
Comment at: clang/test/Driver/arm-float-abi-runtime-path.c:14
+// RUN: -resource-dir=%S/Inputs/arm_float_abi_runtime_path 2>&1 | FileCheck -check-prefix=ARM %s
+// RUN: %clang %s -target armv7-unknown-linux-gnueabi -print-runtime-dir \
+// RUN: -resource-dir=%S/Inputs/arm_float_abi_runtime_path 2>&1 | FileCheck -check-prefix=ARM %s
----------------
Having one of armv7/armv8l is sufficient.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110142/new/
https://reviews.llvm.org/D110142
More information about the cfe-commits
mailing list