[PATCH] D110142: [clang][Driver] Correct runtime path for Arm hard float targets

[Fangrui Song via Phabricator via cfe-commits]

MaskRay added a comment.

Do you know why `--target=armv8l-unknown-linux-gnueabihf` picks `armhf-unknown-linux-gnueabihf` instead of `armv8l-unknown-linux-gnueabihf`?
(For new tests, prefer `--target=` to `-target `; space separated driver options are not the convention.)

The direction the Clang driver should move to is less magic. See D109727 <https://reviews.llvm.org/D109727>



================
Comment at: clang/lib/Driver/ToolChain.cpp:492
+  llvm::Triple triple = getTriple();
+  RegisterEffectiveTriple TripleRAII(*this, triple);
+  auto arch_name = getArchNameForCompilerRTLib(*this, Args);
----------------
Add a comment similar to 

// --target=armv8l-unknown-linux-gnueabi prefers to change the machine part to arm{,hf}. The os part may change to gnueabi{,hf}.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110142/new/

https://reviews.llvm.org/D110142