[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space
Anastasia Stulova via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 21 03:40:14 PDT 2021
Anastasia added a comment.
In D109874#3011792 <https://reviews.llvm.org/D109874#3011792>, @Topotuna wrote:
> Both comments addressed. Personally, I would shuffle words around to rename helper function as `getDefaultOpenCLPointeeAddrSpace` or `getOpenCLDefaultPointeeAddrSpace`. Although I am not sure if there are some assumed naming conventions in Clang. Originally, I was following the name of `getDefaultCXXMethodAddrSpace`.
I agree this naming scheme makes more sense.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109874/new/
https://reviews.llvm.org/D109874
More information about the cfe-commits
mailing list