[PATCH] D109874: [OpenCL] Defines helper function for OpenCL default address space

Justas Janickas via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 21 03:20:49 PDT 2021


Topotuna marked 2 inline comments as done.
Topotuna added a comment.

Both comments addressed. Personally, I would shuffle words around to rename helper function as `getDefaultOpenCLPointeeAddrSpace` or `getOpenCLDefaultPointeeAddrSpace`. Although I am not sure if there are some assumed naming conventions in Clang. Originally, I was following the name of `getDefaultCXXMethodAddrSpace`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109874/new/

https://reviews.llvm.org/D109874



More information about the cfe-commits mailing list