[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

Mon Sep 13 12:03:02 PDT 2021

catenacyber added a comment.

> .profraw are files with the raw profile format. The compiler-rt/lib/profile runtime and llvm-profdata only support one version at any commit.

Ok.

> Mixing .profraw files produced by different compiler-rt/lib/profile runtimes is unsupported.

I do not think I am mixing profraw files as I have only one profraw file.
If my llvm-profdata is not supporting the profraw file produced by rust + linker, should it not error with
` Unsupported instrumentation profile format version` instead of `malformed instrumentation profile data`
As it does with rust nightly and clang 12 ?

> I don't know what rustc and https://github.com/ctz/rustls do.

Rustls is just an example rust project, I think we get the same result with every rust project.

> I don't think this change is responsible as the change has been well released/tested by many C++ groups.

I guess I did not mean to use the word responsible.
I am just saying that if I `git revert a1532ed27582038e2d9588108ba0fe8237f01844` and solve the conflicts on top of main, I get my scenario to work again

> If Rust adapts compiler-rt and does something different, I think the investigation responsibility is on Rust's side.
>
> Perhaps you can get some help from rustc folks who do the compiler-rt adaptation in rustc.

I am asking indeed

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104556/new/

https://reviews.llvm.org/D104556