[PATCH] D104556: [InstrProfiling] Make CountersPtr in __profd_ relative

Mon Sep 13 11:54:20 PDT 2021

MaskRay added a comment.

In D104556#2998137 <https://reviews.llvm.org/D104556#2998137>, @catenacyber wrote:

>> Bump the raw profile format version to 6. (Last bump happened in 2019-10.)
>
> This does not seem to be in the patch, ie no change of `INSTR_PROF_RAW_VERSION` in compiler-rt/include/profile/InstrProfData.inc
> Is that missing ?

`INSTR_PROF_RAW_VERSION` is not bumped. It was bumped in the first revision of this patch if you looked at the history.

Somehow the binary ID change got pushed before this and it has been rolled back/forward several times in main.
The version is not updated to not cause unnecessary conflict with that patch.

Even if `INSTR_PROF_RAW_VERSION` is bumped, I think it is very likely your Rust downstream will observe an `if (GET_VERSION(Version) != RawInstrProf::Version)` error in llvm-profdata,
because from your description it seems you are likely mixing raw profile files produced by compiler-rt/lib/profile built at different commits.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104556/new/

https://reviews.llvm.org/D104556