[PATCH] D108794: Fully qualify template template parameters when printing

[Richard Trieu via Phabricator via cfe-commits]

rtrieu accepted this revision.
rtrieu added a comment.
This revision is now accepted and ready to land.

In D108794#2978134 <https://reviews.llvm.org/D108794#2978134>, @dblaikie wrote:

> Ping
>
> In D108794#2976063 <https://reviews.llvm.org/D108794#2976063>, @rtrieu wrote:
>
>> It looks like a strict improvement on printing and most callers using the default args won't need to be updated.
>>
>> There's one more function call that should be updated:
>> https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/DumpAST.cpp#L298
>>
>> Fixing that and the comment and this should be good to go in.
>
> Ah, thanks for catching that (just running `check-clang` doesn't catch this, and it doesn't seem like there's a `check-clang-tools-extra` - any idea if there's something narrower than `check-all` that would run clang-tools-extra tests?). Updated that caller to preserve the existing unqualified behavior.

I don't know if there is a better way to check.  I found it by doing a quick search over the code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108794/new/

https://reviews.llvm.org/D108794