[PATCH] D108794: Fully qualify template template parameters when printing

Wed Sep 1 15:26:21 PDT 2021

dblaikie marked an inline comment as done.
dblaikie added a comment.

Ping

In D108794#2976063 <https://reviews.llvm.org/D108794#2976063>, @rtrieu wrote:

> It looks like a strict improvement on printing and most callers using the default args won't need to be updated.
>
> There's one more function call that should be updated:
> https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/clangd/DumpAST.cpp#L298
>
> Fixing that and the comment and this should be good to go in.

Ah, thanks for catching that (just running `check-clang` doesn't catch this, and it doesn't seem like there's a `check-clang-tools-extra` - any idea if there's something narrower than `check-all` that would run clang-tools-extra tests?). Updated that caller to preserve the existing unqualified behavior.

================
Comment at: clang/include/clang/AST/TemplateName.h:318-320
   /// \param SuppressNNS if true, don't print the
   /// nested-name-specifier that precedes the template name (if it has
   /// one).
----------------
rtrieu wrote:
> Update this comment to reflect the enum.
Oh, for sure, thanks for the pointer!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108794/new/

https://reviews.llvm.org/D108794