[PATCH] D108905: [ItaniumCXXABI] Set nounwind on __cxa_begin_catch/__cxa_end_catch

Mon Aug 30 00:01:59 PDT 2021

ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.

In D108905#2971773 <https://reviews.llvm.org/D108905#2971773>, @MaskRay wrote:

> In D108905#2971761 <https://reviews.llvm.org/D108905#2971761>, @ChuanqiXu wrote:
>
>> Thanks for looking into this!
>> I am not familiar with exception handling. But from the comments, I worried that if it is a problem if there are exceptions whose destructor could throw (although it is not usual nor good).
>
> GCC does not emit call site records for the `__cxa_end_catch` region, so I believe it makes the same assumption.
> Setting `nounwind` should be safe...

Make sense to me. Thanks for looking into this!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108905/new/

https://reviews.llvm.org/D108905