[PATCH] D108905: [ItaniumCXXABI] Set nounwind on __cxa_begin_catch/__cxa_end_catch nounwind

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 30 00:00:10 PDT 2021


MaskRay added a comment.

In D108905#2971761 <https://reviews.llvm.org/D108905#2971761>, @ChuanqiXu wrote:

> Thanks for looking into this!
> I am not familiar with exception handling. But from the comments, I worried that if it is a problem if there are exceptions whose destructor could throw (although it is not usual nor good).

GCC does not emit call site records for the `__cxa_end_catch` region, so I believe it makes the same assumption.
Setting `nounwind` should be safe...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108905/new/

https://reviews.llvm.org/D108905



More information about the cfe-commits mailing list