[PATCH] D103807: [clang][deps] Ensure deterministic order of TU '-fmodule-file=' arguments
Duncan P. N. Exon Smith via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 23 09:01:42 PDT 2021
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
Another option to be aware of is `MapVector` (https://llvm.org/docs/ProgrammersManual.html#llvm-adt-mapvector-h). Does not sort, but guarantees iteration order.
But LGTM anyway. I don't think the exact data structure is important here. Please just add a comment documenting that consumers need a deterministic iteration order so anyone updating or optimizing this later knows what the constraints are.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103807/new/
https://reviews.llvm.org/D103807
More information about the cfe-commits
mailing list