[PATCH] D103807: [clang][deps] Ensure deterministic order of TU '-fmodule-file=' arguments
Jan Svoboda via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 23 05:59:52 PDT 2021
jansvoboda11 requested review of this revision.
jansvoboda11 added a comment.
I'm aware of the drawbacks of `std::map`, but I think having the container sorted at all times promotes correctness/determinism which we really care about in this context. Forgetting to call `sort` at all the right places is very easy as this patch demonstrates.
But if you are strongly opposed to using `std::map` here, I'm okay with using `std::unordered_map` or `llvm::StringMap` and sorting where necessary.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103807/new/
https://reviews.llvm.org/D103807
More information about the cfe-commits
mailing list