[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation

Mon Aug 23 04:47:28 PDT 2021

jaykang10 added a comment.

In D108470#2959715 <https://reviews.llvm.org/D108470#2959715>, @svenvh wrote:

> In D108470#2959708 <https://reviews.llvm.org/D108470#2959708>, @jaykang10 wrote:
>
>> Can you also add "double2_to_float3"
>
> Instead of `double2_to_float3`, I decided to add `char8_to_short3`.  Same idea (vectorN to vector3), but reinterpreting 8 chars as 3 shorts feels like a more realistic case than reinterpreting 2 doubles as 3 floats.  But I'm happy to add `double2_to_float3` if you think there is a good reason to do so.

I am sorry for asking more tests because I did not add enough tests previously.
I do not know well how many type conversions with vec3 the recent OpenCL spec cover but it could be good to add more the tests of the type conversions which the spec mentions. If you feel the tests you have added are enough for it, I am ok with it.

>> and "float4_to_float3" tests please?
>
> That test is already there, see line 17.

Sorry, I missed it.

LGTM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108470/new/

https://reviews.llvm.org/D108470