[PATCH] D108470: [OpenCL] Fix as_type3 invalid store creation
Sven van Haastregt via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 23 04:22:30 PDT 2021
svenvh added a comment.
In D108470#2959708 <https://reviews.llvm.org/D108470#2959708>, @jaykang10 wrote:
> Can you also add "double2_to_float3"
Instead of `double2_to_float3`, I decided to add `char8_to_short3`. Same idea (vectorN to vector3), but reinterpreting 8 chars as 3 shorts feels like a more realistic case than reinterpreting 2 doubles as 3 floats. But I'm happy to add `double2_to_float3` if you think there is a good reason to do so.
> and "float4_to_float3" tests please?
That test is already there, see line 17.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108470/new/
https://reviews.llvm.org/D108470
More information about the cfe-commits
mailing list