[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool

[Joseph Huber via Phabricator via cfe-commits]

jhuber6 added a comment.

In D107668#2939365 <https://reviews.llvm.org/D107668#2939365>, @yaxunl wrote:

> This may break -save-temps since the input to clang-offload-bundler may not be temporary files when -save-temps is enabled.
>
> I think clang-offload-bundler is not the right place to decide whether a file is a temporary file. Whether a file is a temporary file should be determined at its point of creation and if it is a temporary file it should be addTempFile there, instead of guessing that later.

The `.cubin` files are still present when I tested it with `save-temps`. We already do something similar in the OpenMPLinker job for the Cuda driver, which is why these files were removed for straight compilation but kept when using the offload bundler when compiling with `-c`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107668/new/

https://reviews.llvm.org/D107668