[PATCH] D107668: [OpenMP]Fix PR50336: Remove temporary files in the offload bundler tool
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 11 07:13:04 PDT 2021
yaxunl added a comment.
This may break -save-temps since the input to clang-offload-bundler may not be temporary files when -save-temps is enabled.
I think clang-offload-bundler is not the right place to decide whether a file is a temporary file. Whether a file is a temporary file should be determined at its point of creation and if it is a temporary file it should be addTempFile there, instead of guessing that later.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107668/new/
https://reviews.llvm.org/D107668
More information about the cfe-commits
mailing list