[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12090
+      OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction());
+      Remark << "An FP atomic instruction was expanded into a CAS loop.";
+      return Remark;
----------------
Using FP abbreviation is unclear. IIRC there shouldn't be an end period in messages


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12096
+      OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction());
+      Remark << "An unsafe hardware instruction was generated.";
+      return Remark;
----------------
This message seems concerning. Unless you already know everything about this instruction, it doesn't really help you.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12100
+  }
+  delete ORE;
+  return Kind;
----------------
Should not need to create and delete, the analysis pass should own this


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106891/new/

https://reviews.llvm.org/D106891