[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks when an FP atomic instruction is converted into a CAS loop or unsafe hardware instruction for GFX90A

Matt Arsenault via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Jul 30 09:03:50 PDT 2021


arsenm added a comment.

Needs an IR only test too



================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12086
+                   TargetLowering::AtomicExpansionKind Kind, bool UnsafeFlag) {
+  ORE = new OptimizationRemarkEmitter(RMW->getFunction());
+  if (Kind == TargetLowering::AtomicExpansionKind::CmpXChg) {
----------------
This is supposed to come from the pass, I don't think you can materialize this out of nowhere


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106891/new/

https://reviews.llvm.org/D106891



More information about the cfe-commits mailing list