[PATCH] D106862: [clang][modules] Avoid creating partial FullSourceLoc for explicit modules imports
Duncan P. N. Exon Smith via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jul 29 17:17:20 PDT 2021
dexonsmith added a comment.
In D106862#2913815 <https://reviews.llvm.org/D106862#2913815>, @arphaman wrote:
> I think this approach makes sense for now. It's unfortunate that the constructor of FullSourceLoc is unable to validate this requirement, do you know how many clients that you describe as modifying their ID to make them valid are there?
(Maybe an `Optional<FullSourceLoc>` would work for those clients?)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106862/new/
https://reviews.llvm.org/D106862
More information about the cfe-commits
mailing list