[PATCH] D106862: [clang][modules] Avoid creating partial FullSourceLoc for explicit modules imports

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 29 08:18:41 PDT 2021


arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.

I think this approach makes sense for now. It's unfortunate that the constructor of FullSourceLoc is unable to validate this requirement, do you know how many clients that you describe as modifying their ID to make them valid are there?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106862/new/

https://reviews.llvm.org/D106862



More information about the cfe-commits mailing list