[PATCH] D98799: [UniqueLinkageName] Use consistent checks when mangling symbo linkage name and debug linkage name.

Tue Jul 6 17:05:16 PDT 2021

hoy added a comment.

In D98799#2860881 <https://reviews.llvm.org/D98799#2860881>, @dblaikie wrote:

> In D98799#2850700 <https://reviews.llvm.org/D98799#2850700>, @dblaikie wrote:
>
>> In D98799#2850682 <https://reviews.llvm.org/D98799#2850682>, @ahatanak wrote:
>>
>>> I think I've fixed all the places in CodeGen that create fake `FunctionDecl`s and would cause clang to crash.
>>
>> Thanks, I really appreciate it! I'll have a go at unifying this mangled V unique internal linkage name stuff soon.
>
> Committed a patch to resolve the inconsistencies with K&R declarations, `__attribute__((overloadable))` (which would mangle overloadable K&R declarations, but would not attach the mangled name to the debug info metadata), and `-funique-internal-linkage-names` (which wouldn't mangle/suffix K&R declarations (but would make this choice consistently between debug info and the actual symbol name) - now all those cases can/do mangle the names: 6c9559b67b91966bfeff9e17808a3e84a92e64a0 <https://reviews.llvm.org/rG6c9559b67b91966bfeff9e17808a3e84a92e64a0>

Thanks for the fix!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98799/new/

https://reviews.llvm.org/D98799