[PATCH] D104766: [X86] Zero some outputs of Keylocker intrinsics in error case

Fri Jul 2 01:02:46 PDT 2021

xiangzhangllvm added inline comments.

================
Comment at: clang/lib/CodeGen/CGBuiltin.cpp:14834

+    BasicBlock *NoError = createBasicBlock(StrNoErr, this->CurFn);
+    BasicBlock *Error = createBasicBlock(StrErr, this->CurFn);
----------------
craig.topper wrote:
> Sorry I'm late here. Instead of having 3 separate strings for each intrinsic can you do something like `createBasicBlock(BaseName + "_no_error"...)` here. I believe createBasicBlock takes a Twine.
Hello Craig! Nice to meet you again :) , Sorry for not noticing you this patch before. I planned  not to disturb you if not necessary.

Yes, using Twine will more clear, let me refine it. Thanks a lot!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104766/new/

https://reviews.llvm.org/D104766